fix: PDB archive shards and output layout#9
Merged
youngdashu merged 3 commits intomainfrom Apr 9, 2026
Merged
Conversation
- Name per-shard zips from path relative to data_path to avoid pdbs.h5 collisions
- Remove redundant tar.gz wrapper around zip shards
- Write shard and final merged zips to {data_path}/archives/{dataset}/
- Open H5 paths from index keys directly; pass data_path for naming
- Add unit tests for _shard_zip_name
Made-with: Cursor
Collaborator
|
Works fine but we don't need the full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
create_archiveso multi-batch H5 layouts (.../<batch>/pdbs.h5) no longer overwrite the samepdbs.zip, removes the redundant.tgzwrapper around zip shards, and writes shard zips plus the merged archive under${data_path}/archives/<dataset_dir_name>/instead ofdatasets/.../archivesandcwd().Tests
tests/test_archive.pycovers distinct shard zip names for same basename and long paths.Made with Cursor